Percy: GraphQL Mock Server #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
changed the title
# Conflicts: # lib/util/config-types.ts
add `mutedErrors` itinerary config feature
|
I can't figure out why the results in CI differ from the local results. In the snapshots:
Neither of these seem to be a problem locally, only in CI. Then also the mobile view tests just fail entirely and I do not know why that is. |
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
Assigning back to you until the fixes we did together are in |
|
What are you stuck on right now again? |
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new express.js server that handles GraphQL requests separately from REST requests. REST is handled by the HAR library that we already had, while GraphQL requests are handled by a GraphQL handler so that we can mock individual types on the GraphQL query and make decisions based on the arguments to it.
| Before | After |
| 
|
|--------|-------|
|